Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable -Wnewline-eof #4896

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Enable -Wnewline-eof #4896

merged 1 commit into from
Oct 28, 2022

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Oct 28, 2022

It enforces the newline at end of file, which is required by the C standard.

Copy link
Contributor

@nikkhils nikkhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #4896 (a690b12) into main (d8e892a) will increase coverage by 1.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4896      +/-   ##
==========================================
+ Coverage   89.50%   91.13%   +1.62%     
==========================================
  Files         225      224       -1     
  Lines       50238    48170    -2068     
==========================================
- Hits        44968    43898    -1070     
+ Misses       5270     4272     -998     
Impacted Files Coverage Δ
src/nodes/hypertable_modify.c 96.19% <ø> (+60.40%) ⬆️
src/import/allpaths.c 83.67% <100.00%> (+3.05%) ⬆️
src/loader/function_telemetry.c 100.00% <100.00%> (ø)
src/nodes/chunk_append/chunk_append.c 98.20% <100.00%> (+0.55%) ⬆️
src/planner/constify_now.c 98.11% <100.00%> (-0.06%) ⬇️
src/planner/expand_hypertable.c 94.37% <100.00%> (+0.13%) ⬆️
src/planner/planner.c 95.76% <100.00%> (-0.05%) ⬇️
src/planner/space_constraint.c 94.37% <100.00%> (+0.25%) ⬆️
tsl/src/fdw/deparse.c 71.63% <100.00%> (+2.40%) ⬆️
tsl/src/nodes/decompress_chunk/decompress_chunk.c 94.89% <100.00%> (-0.19%) ⬇️
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c48b123...a690b12. Read the comment docs.

It enforces the newline at end of file, which is required by the C
standard.
@akuzm akuzm merged commit 5b2d9d5 into timescale:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants